On Tue, Aug 24, 2010 at 01:41:14AM -0500, Jonathan Nieder wrote: > Like $GIT_CONFIG, $GIT_CONFIG_PARAMETERS needs to be suppressed by > "git push" and its cousins when running local transport helpers to > imitate remote transport well. Thanks, this looks good to me. Though arguably these bits: > +#define CONFIG_DATA_ENVIRONMENT "GIT_CONFIG_PARAMETERS" > [...] > - const char *old = getenv("GIT_CONFIG_PARAMETERS"); > + const char *old = getenv(CONFIG_DATA_ENVIRONMENT); Should be squashed into the original patch. :) -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html