On Sat, Aug 21, 2010 at 10:27 AM, Junio C Hamano <gitster@xxxxxxxxx> wrote: > Nguyễn Thái Ngọc Duy <pclouds@xxxxxxxxx> writes: > >> clone_local() function disregards --depth. Make it more apparent. >> Also hint users that file:// works with --depth. > > Hmm---why? > > The "--depth" option is an ugly hack that tries to conserve network > bandwidth and disk usage, which is not necessary if you are doing a local > hardlinking clone. Without this patch we allowed people to clone with the > option without a downside (allowing it didn't result in broken repository, > for example), but with it, what has long been allowed suddenly stops > working. Is the breakage justifiable? I also expect it to cut down history too. Maybe it's just me, when I say --depth=3, 'git log' should give me more or less 3 commits regardless what kind of transport I use to clone. Or we could make it a warning, "--depth is ignored in local clone"? -- Duy -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html