--- Jakub Narebski <jnareb@xxxxxxxxx> wrote: > Luben Tuikov wrote: > > --- Jakub Narebski <jnareb@xxxxxxxxx> wrote: > >> Jakub Narebski wrote: > >>> Add a kind of "next" view in the bottom part of navigation bar for > >>> "commitdiff" view. > >>> > >>> For commitdiff between two commits: > >>> (from: _commit_) > >>> For commitdiff for one single parent commit: > >>> (parent: _commit_) > >>> For commitdiff for one merge commit > >>> (merge: _commit_ _commit_ ...) > >>> For commitdiff for root (parentless) commit > >>> (initial) > >>> where _link_ denotes hyperlink. SHA1 is shortened to 7 characters on > >>> display, everything is perhaps unnecessary esc_html on display. > [...] > >> > >> Any reasons not to accept this patch? I find it very useful. > >> > >> The idea to use fixed string instead of shortened SHA-1 of commit > >> was abandoned after some discussion in this thread. > > > > I prefer using the commit-8 without any "..." postfixed. Anyone who > > knows squat about git knows very well what a commit-8 is when they > > see one -- the first 8 hexadecimal digits of the full SHA-1. > > > > I like using "next" only when there is a "prev" right next to it, > > i.e. based on _context_, something like this: > > << prev next>> > > where "<< prev" is hyperlinked, and "next>>" is also. > > Unfortunately this is simply not possible in this case, as links in git > are only from commit to paren(a), in one direction only. I was not suggesting that. I simply saw a "next" suggestion in this thread and wanted to mention about "next", "prev" and context. > It is commit-7, but that can be easily changed. Please do change it to "commit-8" -- it'd be consistent with the rest of GIT. > > Acked-by: Luben Tuikov <ltuikov@xxxxxxxxx> > > (not that it matters in any way ;-) ) > > IIRC Junio asked for ACKs. In this email, it seems that he's asking for, quoting, "Acked-by:": http://marc.theaimsgroup.com/?l=git&m=116206206008374&w=2 Luben - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html