Re: [PATCH 0/5] Update compat/regex

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



2010/8/17 Jonathan Nieder <jrnieder@xxxxxxxxx>:
> Junio C Hamano wrote:
>
>> Hmm, is there [1/5] in the series?
>
> Yes, but it probably missed the list because of vger's message length
> limits.
>
> For convenience, here is the series.  I also think the first two
> patches should be combined, but this does not do so because others
> might disagree.  Patch 5 (autoconf) is the v2 version.

Pedantic: If there's going to be squashing that should probably
include the regerror change too, otherwise it can't be bisected on
MSVC either.

Personally I think nothing should be squashed, because the history of
having 1 commit be the unaltered gawk library and the rest being the
changes we need on top of it will help future developers when we need
to update the regex library again.

And since most people hacking git probably do so on GNU or the BSD's
which don't need NO_REGEX=YesPlease the practical downside of doing so
is *very* little.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]