On Wed, Aug 18, 2010 at 9:29 AM, Johannes Sixt <j.sixt@xxxxxxxxxxxxx> wrote: > Am 8/18/2010 1:27, schrieb Tor Arvid Lund: >> I often use git-gui when staging commits, and I noticed that if the >> file I'm working with has a: >> >> \ No newline at end of file >> >> ... as the last line of the diff, and I try to "Stage lines for >> commit", then git-gui (or really git-apply, as I understand it) says >> that I have a "corrupt patch at line <so-and-so>". >> >> Is this a bug? Or is it maybe git-gui that sends something wrong to >> git-apply? I don't know... :-/ > > This is really a bug in git-gui, not in git-apply: The big while loop in > lib/diff.tcl, function apply_range_or_line, must be taught about "\ No > newline...". Ok, thanks for tracking it down. I suspected this, since the tests for git-apply seemed to have example patches for "\ No newline...". Ultimately, this doesn't scratch me enough that I want to learn (or guess) how to fix the Tcl stuff... -Tor Arvid- -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html