Re: [RFC/PATCH 1/2] commit: add parse_commit_repl() to replace commits at parsing time

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Aug 18, 2010 at 2:24 PM, Jonathan Nieder <jrnieder@xxxxxxxxx> wrote:
> Christian Couder wrote:
>
>> The downside is that the sha1 will not be
>> consistent with the content anymore and that it will be more difficult to
>> realize that an object has been replaced as there will be no sha1 change to be
>> seen.
>
> Maybe in the long run it would make sense to keep a "replaced" flag
> and use it to mark the replace objects specially in some user-facing
> commands (like log --format=medium).

Sounds good (if uses really need to know that). It can be used for
commit grafts too.

You would need to find an available bit flag first though. Currently
object.flags is used for different purposes and its bit definitions
are not centralized. So it's hard to find a "good" bit that no one
uses yet, to become the "replaced" bit. OK I'm getting off-topic now.
-- 
Duy
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]