Re: [PATCH] git-svn: fix fetch with deleted tag

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, August 14, 2010 at 7:52:48 AM, Ævar Arnfjörð Bjarmason wrote:


> On Sat, Aug 14, 2010 at 14:07, David D. Kilzer <ddkilzer@xxxxxxxxxx> wrote:
> >  +++ b/t/t9156-git-svn-fetch-deleted-tag-2.sh
> >  @@ -0,0 +1,45 @@
> > +#!/bin/sh
> > +
> > +test_description='git  svn fetch deleted tag 2'
> 
> Any reason not to include both of these in the  same file? Just to
> avoid having to manually reset the  repository?


It was easier to run the tests individually when working on them, and I was 
hesitant to combine the setup steps from each test since it wouldn't be as clear 
which steps were for which test in the future.  I realize this may be slower 
when running the tests, but it makes them easier to maintain, especially when 
one hasn't looked at the tests in a while.

Is there a nice way to reset the repository between steps?

Thanks for the feedback!  I've already applied your other suggestions.

Dave

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]