On 08/03/2010 02:50 PM, Jakub Narebski wrote:
+
+ my $title = to_utf8("Search for commits $performed by $author");
+ $title =~ s/[[:cntrl:]]/?/g;
+
Isn't it possible that other data coming from git could have escape characters in them such as the commit subject line? In which case this same bug would occur?
Therefore isn't it better to strip out control characters (that's what this patch is doing right?) in esc_html?
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html