On Sat, Aug 14, 2010 at 03:40, Mark Lodato <lodatom@xxxxxxxxx> wrote: > On Fri, Aug 13, 2010 at 11:23 PM, Ævar Arnfjörð Bjarmason <avarab@xxxxxxxxx> wrote: >> On Sat, Aug 14, 2010 at 03:17, Mark Lodato <lodatom@xxxxxxxxx> wrote: >>> On Tue, Aug 3, 2010 at 10:57 PM, Mark Lodato <lodatom@xxxxxxxxx> wrote: >>>> Modify git-completion.bash to work with both bash and zsh. Most code >>>> works fine, but a few things need tweaking. Where possible, code is >>>> written in such a way that both shells interpret fine, but some areas >>>> need special-casing. >>> >>> Is there any interest in this patch, or anything I could do that would >>> make it more likely to be accepted? Perhaps at least some of these >>> changes could be implemented. >> >> What's the Message-ID for that patch? I can't find it in my mailbox or >> in a public archive (via Google). > > Thanks for letting me know. > > It appears that my initial message didn't go through. I used the --to > argument with 'git format-patch', but 'git send-email' didn't seem to > parse it properly. It stuck an empty "To:" line at the normal position, > and then put an additional "To: git@xxxxxxxxxxxxxxx" at the bottom of > the headers. Gmail must not have liked this. > > So, here's another shot. I am not too familiar with how the completion > works, so the changed parts ought to be tested on both zsh and bash. > Any suggestions on how to do so - or results from doing so - would be > greatly appreciated. > > I tried to make as few changes to the main part of the script as > possible, so that zsh compatibility does not get in the way of normal > development. If anyone has any suggestions for improvement, please let > me know. > > If this should be split into separate patches, I can do that. Each > change is so small, I thought it would make more sense to roll them all > into one. It makes more sense as one patch. It could use something in the comments at the top mentioning that this is supposed to work on zsh too, otherwise it looks good (but I'm not familiar with this code), it's a pretty minimal change for a big win. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html