On Fri, Aug 13, 2010 at 22:02, Johannes Sixt <j6t@xxxxxxxx> wrote: > We do not have the necessary libraries and tools. Just curious, do you mean Windows / MINGW can't build gettext, or that you just haven't done so in your build process yet? At least http://www.mingw.org/wiki/LibrariesAndTools seems to indicate that libintl has been ported to Windows. If you're just not interested in building gettext by default on Windows I think it's completely reasonable to add it to the Makefile (given that you're probably pretty much the only one doing so). It would just be useful to clarify the "why". > Signed-off-by: Johannes Sixt <j6t@xxxxxxxx> > --- > It is necessary to move the first check for NO_GETTEXT after the > configuration section. > > NEEDS_LIBINTL receives a default setting before the configuration > section (not visible in the patch text), hence, I have to unset it > when NO_GETTEXT is set. Perhaps you have a better idea to arrange > these settings. This seems backwards. Instead of removing the check from the LIB_OBJS assignment and adding it in later I think we could just move the giant "Platform specific tweaks" section so that it appears before all those assignments, and directly after "export PYTHON_PATH". I tried doing so locally and Git builds and tests fine, but I've only done so on one platform, so I might have missed something. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html