Ævar Arnfjörð Bjarmason <avarab@xxxxxxxxx> writes: > Remove the setlocale/LC_CTYPE call from gettext.c, we only need > setlocale/LC_MESSAGES to use the message catalog, and setting LC_CTYPE > from the environment breaks Git's assumptions about C library > functions. > > Under a non-C locale functions like vsnprintf become locale sensitive, > so that they'll e.g. refuse to process ISO-8895-1 data under a UTF-8 > locale. > > This triggered a "your vsnprintf is broken" error on Git's own > repository when inspecting v0.99.6~1 under a UTF-8 locale. > > That commit contains a ISO-8859-1 encoded author name, which the > locale aware vsnprintf(3) won't interpolate in the format argument, > due to mismatch between the data encoding and the locale. Sidenote: This commit was done probably before invention of 'encoding' header, but it should be displayable anyway. -- Jakub Narebski Poland ShadeHawk on #git -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html