Daniel Johnson <computerdruid@xxxxxxxxx> writes: > Originally, if remote.<name>.tagopt was set, the --tags and option would > have no effect when given to git fetch. So if > tagopt="--no-tags" > > git fetch --tags > > would not actually fetch tags. > > This patch changes this behavior to only follow what is written in the > config if there is no option passed by the command line. > > Signed-off-by: Daniel Johnson <ComputerDruid@xxxxxxxxx> > --- > On Sat, Aug 7, 2010 at 10:17 PM, Tay Ray Chuan <rctay89@xxxxxxxxx> wrote: >> On Fri, Aug 6, 2010 at 9:54 PM, Daniel Johnson <computerdruid@xxxxxxxxx> wrote: >>> --- >>> How does this look? >> >> Looks ok - now you'll have to squash this with your code patch. > And here it is. Sorry about the lateness. I also fixed a mistake I made in the > documentation (linked to the wrong secton). > > I'd still like comments on both the code and the change in behavior behind it. The current behaviour seems to me a bug introduced while git-fetch was rewritten in C (the original found in contrib/examples reads from the config only when no --tags/--no-tags option is given from the command line). Is this something we can protect with a test script from future breakages? Thanks. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html