Ævar Arnfjörð Bjarmason <avarab@xxxxxxxxx> writes: > Change this test to skip test with test prerequisites, and to do setup > work in tests. This improves the skipped statistics on platforms where > the test isn't run. > > Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@xxxxxxxxx> > --- > t/t5705-clone-2gb.sh | 11 ++++------- > 1 files changed, 4 insertions(+), 7 deletions(-) > > diff --git a/t/t5705-clone-2gb.sh b/t/t5705-clone-2gb.sh > index e4d1b6a..694e28d 100755 > --- a/t/t5705-clone-2gb.sh > +++ b/t/t5705-clone-2gb.sh > @@ -3,12 +3,9 @@ > test_description='Test cloning a repository larger than 2 gigabyte' > . ./test-lib.sh > > -test -z "$GIT_TEST_CLONE_2GB" && > -skip_all="Skipping expensive 2GB clone test; enable it with GIT_TEST_CLONE_2GB=t" && > -test_done && > -exit > +test -n "$GIT_TEST_CLONE_2GB" && test_set_prereq CLONE_2GB In your 6/7 you preserve the "skipping" message with "say"; don't you want to do the same here? -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html