Junio C Hamano <gitster@xxxxxxxxx> writes: > Matthieu Moy <Matthieu.Moy@xxxxxxx> writes: > >> +void set_porcelain_error_msgs(const char **msgs, const char *cmd) >> { >> + const char *msg; >> + char *tmp; >> + const char *cmd2 = strcmp(cmd, "checkout") ? cmd : "switch branches"; > > This may have implications to the later i18n effort, but lets ignore it > for now. I don't think it will be too bad. Note that the ? : construct just allows factoring out two messages, but one can easily distinguish all cases and give the complete error message in the source (we don't care about performance/memory here, it's a one-time thing). So, yes, that's easily fixable later if it causes problems to i18n. -- Matthieu Moy http://www-verimag.imag.fr/~moy/ -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html