[PATCH 2/2] Makefile: add missing dependency on http.h

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



v1.7.1-rc0~65^2~2 (http: init and cleanup separately from
http-walker, 2010-03-02) introduced a direct dependency from
http-fetch on the HTTP request library.  Declare it.

Detected with "make CHECK_HEADER_DEPENDENCIES=1".

Cc: Tay Ray Chuan <rctay89@xxxxxxxxx>
Signed-off-by: Jonathan Nieder <jrnieder@xxxxxxxxx>
---
After this series, “make COMPUTE_HEADER_DEPENDENCIES=YesPlease”
succeeds again.

Ideas for future work:

 - speed up the dependency checker, run it regularly;
 - port COMPUTE_HEADER_DEPENDENCIES to non-gcc compilers so it can
   be used by default;
 - speed up the redundant-dependency detector[1] enough to make it
   usable;
 - autoconf test;
 - “make test-makefile” for cron jobs.

Alas, this series did none of those things.

[1] <20100131231103.GA5287@xxxxxxxxxxxx> which doesn’t seem to
have made it out into the world.  Will resend as reply.

 Makefile |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/Makefile b/Makefile
index 9a233b0..e151516 100644
--- a/Makefile
+++ b/Makefile
@@ -1856,7 +1856,7 @@ builtin/tar-tree.o archive-tar.o: tar.h
 builtin/pack-objects.o: thread-utils.h
 connect.o transport.o http-backend.o: url.h
 http-fetch.o http-walker.o remote-curl.o transport.o walker.o: walker.h
-http.o http-walker.o http-push.o remote-curl.o: http.h
+http.o http-walker.o http-push.o http-fetch.o remote-curl.o: http.h
 
 xdiff-interface.o $(XDIFF_OBJS): \
 	xdiff/xinclude.h xdiff/xmacros.h xdiff/xdiff.h xdiff/xtypes.h \
-- 
1.7.2.1.544.ga752d.dirty

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]