I would have no problem doing that. I was just trying to match the style already present in http.c. All the other pointer tests in that function/file are done the same. On Sat, 2010-08-07 at 08:34 +0000, Ævar Arnfjörð Bjarmason wrote: > On Sat, Aug 7, 2010 at 03:34, Spencer E. Olson <olsonse@xxxxxxxxx> wrote: > > > - curl_easy_setopt(result, CURLOPT_USERAGENT, GIT_USER_AGENT); > > + if (user_agent != NULL) > > + curl_easy_setopt(result, CURLOPT_USERAGENT, user_agent); > > + else > > + curl_easy_setopt(result, CURLOPT_USERAGENT, GIT_USER_AGENT); > > Can't you just skip the != NULL?: > > if (user_agent) > curl_easy_setopt(result, CURLOPT_USERAGENT, user_agent); > else > curl_easy_setopt(result, CURLOPT_USERAGENT, GIT_USER_AGENT); > > -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html