Re: [PATCH] prune: allow --dry-run for -n and --verbose for -v

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Am 06.08.2010 23:04, schrieb Jonathan Nieder:
René Scharfe wrote:

+++ b/builtin/prune.c
@@ -125,10 +125,9 @@ int cmd_prune(int argc, const char **argv, const char *prefix)
  {
  	struct rev_info revs;
  	const struct option options[] = {
-		OPT_BOOLEAN('n', NULL, &show_only,
+		OPT_BOOLEAN('n', "dry-run", &show_only,

For the curious: avoiding OPT__DRY_RUN allows us to give a better
description:

  			"do not remove, show only"),

which makes sense to me.  Thanks.

Indeed.

Adding a helptext parameter to OPT__DRY_RUN à la OPT__COLOR would make it usable here as well as in commit.c and fetch.c. Similar changes could help OPT__VERBOSE and OPT__QUIET. Their standard helptexts don't add a lot of information..

René
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]