"Asgeir S. Nilsen" <asgeir@xxxxxxxxxxx> writes: > Signed-off-by: Asgeir S. Nilsen <asgeir@xxxxxxxxxxx> > --- > contrib/ciabot/ciabot.sh | 2 +- > contrib/examples/git-checkout.sh | 2 +- > ... > contrib/examples/git-verify-tag.sh | 2 +- > contrib/fast-import/git-import.sh | 2 +- > contrib/git-resurrect.sh | 2 +- > contrib/hooks/post-receive-email | 2 +- > contrib/hooks/pre-auto-gc-battery | 2 +- > contrib/remotes2config.sh | 2 +- > contrib/rerere-train.sh | 2 +- > contrib/workdir/git-new-workdir | 2 +- Thanks. The ones in contrib/examples used to be part of git and they were meant to get their shebang "#!/bin/sh" line replaced by the toplevel Makefile to whatever shell suitable on the platform. As you already know, /bin/sh on Solaris is non-POSIX and we recommend people to use a POSIX compilant shell. The current Makefile suggests /bin/bash on Solaris, but either ksh or /usr/xpg[46]/bin/sh should work. So a NAK on contrib/examples/ part. And replacing /bin/sh with /bin/bash for everybody is _wrong_, as bash is not the only POSIX compliant shell. Some of the scripts in contrib/ may be using bash-specific construct, but I think they are already marked with "#!/bin/bash" on their first lines. If there are some that use bash-ism without "#!/bin/bash", we should first try to see if we can reasonably rewrite them to avoid bash-ism, and mark them as bash scripts if we can't. I wounld't be so surprised if there are some, but what I sampled randomly while writing this response were pure POSIX as far as I can tell. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html