Jakub Narebski <jnareb@xxxxxxxxx> writes: > Matthieu Moy <Matthieu.Moy@xxxxxxx> writes: > >> +static inline int short_opt(char opt, const char **argv, >> + const char **optarg) > [...] >> +int parse_long_opt(const char *opt, const char **argv, >> + const char **optarg) > > Just a nitpick question: why it is 'parse_long_opt' but just > 'short_opt'? I initially made *_long_opt prefixed with something (diff_ in my first version) because it's global, while short_opt is static. parse_short_opt is already taken in parse-option.c, so I'd rather avoid re-using it (it's static there, so technically, we can, but ...). -- Matthieu Moy http://www-verimag.imag.fr/~moy/ -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html