Re: [PATCH] git-svn: URL-decode the left-hand side of an svn refspec

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Aug 4, 2010 at 4:38 AM, Eric Wong <normalperson@xxxxxxxx> wrote:
> Thanks Steven.
>
> Since git-svn already has a uri_decode() function, we should use that.
> The decoding should apply to the local portion of branches/tags globs,
> too.  Does the following work for you?
>
> diff --git a/git-svn.perl b/git-svn.perl
> index 8d2ef3d..34884b8 100755
> --- a/git-svn.perl
> +++ b/git-svn.perl
> @@ -1820,6 +1820,7 @@ sub read_all_remotes {
>                        die("svn-remote.$remote: remote ref '$remote_ref' "
>                            . "must start with 'refs/'\n")
>                                unless $remote_ref =~ m{^refs/};
> +                       $local_ref = uri_decode($local_ref);
>                        $r->{$remote}->{fetch}->{$local_ref} = $remote_ref;
>                        $r->{$remote}->{svm} = {} if $use_svm_props;
>                } elsif (m!^(.+)\.usesvmprops=\s*(.*)\s*$!) {
> @@ -1832,6 +1833,7 @@ sub read_all_remotes {
>                        die("svn-remote.$remote: remote ref '$remote_ref' ($t) "
>                            . "must start with 'refs/'\n")
>                                unless $remote_ref =~ m{^refs/};
> +                       $local_ref = uri_decode($local_ref);
>                        my $rs = {
>                            t => $t,
>                            remote => $remote,
> --
> Eric Wong
>

Yes, this works.  Thanks!
-- 
-Steven Walter <stevenrwalter@xxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]