Junio C Hamano <gitster@xxxxxxxxx> writes: > Nguyễn Thái Ngọc Duy <pclouds@xxxxxxxxx> writes: > >> From: Jonathan Nieder <jrnieder@xxxxxxxxx> >> >> Tweak the rest of the script to more closely follow the test >> style guide. Guarding setup commands with test_expect_success >> makes it easy to see the scope in which some particular data is >> used; removal of whitespace after >redirection operators is just >> for consistency. >> >> Signed-off-by: Jonathan Nieder <jrnieder@xxxxxxxxx> >> Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@xxxxxxxxx> > > What happened to the 'test -z "$(cmd)" discards exit status from cmd' part > of Jonathan's patch? Sorry, I was confused. Please disregard the above; it took me a while to realize that this 5-patch series is a re-roll of what I queued, which in turn Jonathan's nitpick is based on, and you took the advice while redoing 2/5. Thanks. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html