Re: [RFC/PATCH] rebase -i: add run command to launch a shell command

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jul 30, 2010 at 15:24, Matthieu Moy
<Matthieu.Moy@xxxxxxxxxxxxxxx> wrote:
> Marc Branchaud <marcnarc@xxxxxxxxxxx> writes:
>
>>> The name of the command may be subject to discussions. I've chosen
>>> "run", but maybe "shell" would be OK too. In both cases, it doesn't
>>> allow the one-letter version since both "r" and "s" are already used.
>>
>> "exec" with one-letter "x"?
>
> Thanks, that sounds good, yes. Any other thought?

I like "exec".

I think the docs need to elaborate on the environment the "exec"
command gets executed in, what's its current working directory for
instance? Wherever I happened to run git-rebase from? the project
root?

your if ! eval .. error message also exits with 0, surely that should
exit with 1?
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]