Jared Hance wrote:
> Creating a variable nr here to use throughout the function only to change
> refspec_nr to nr at the end, having not used refspec_nr the entire time,
> is rather pointless. Instead, simply increment refspec_nr.
>
> Signed-off-by: Jared Hance <jaredhance@xxxxxxxxx>
[...]
> - int nr = refspec_nr + 1;
> - refspec = xrealloc(refspec, nr * sizeof(char *));
> - refspec[nr-1] = ref;
> - refspec_nr = nr;
> + refspec_nr++;
> + refspec = xrealloc(refspec, refspec_nr * sizeof(char *));
> + refspec[refspec_nr-1] = ref;
While you're already here, you could switch to ALLOC_GROW instead to
avoid the n**2 behaviour of xrealloc...
--
Thomas Rast
trast@{inf,student}.ethz.ch
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html