On Thu, Jul 29, 2010 at 11:16:42AM +0200, Jakub Narebski wrote:
> On Wed, 28 Jul 2010, Pierre Habouzit wrote:
>
> > you cannot take the address of a bit portably in C, so you can't let
> > parseopt set/clear bits through bitfields (as in unsigned field : 1 in a
> > struct in C I mean).
> >
> > So to use parseopt OPTION_BIT feature, you have to convert them to C
> > flags as in "unsigned flags" and explicit masks defines/enums.
> >
> > IOW:
> >
> > struct foo {
> > unsigned bar : 1,
> > ...
> > baz : 1;
> > };
> >
> > Must be converted into:
> >
> > struct foo {
> > #define FOO_FLAG_BAR (1U << 1)
> > ...
> > #define FOO_FLAG_BAZ (1U << 18)
> > unsigned flags;
> > }
> >
> > so that you can use parseopt. that's what I meant.
> >
> >
> > This was done for the rev-list parsing stuff e.g.
>
> e.g. what?
err no, not rev-list, diff options: struct diff_options::flags and the
DIFF_OPT_* defines
--
·O· Pierre Habouzit
··O madcoder@xxxxxxxxxx
OOO http://www.madism.org
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html