Will Palmer <wmpalmer@xxxxxxxxx> writes: > Here's what I propose: > - #define NO_ABBREV 40 > - replace all instances of revs->abbrev = 40 and revs->abbrev = 0 with > revs->abbrev = NO_ABBREV > > That will at least make it explicit and consistent. That is a good idea. I think abbrev == 0 in the early days used to mean "use the compiled-in default, whatever it is" but somehow some codepaths mistakenly used it to mean "please do not abbreviate" (my fault). > ... And an > undefined value should (I think obviously) be interpreted as > DEFAULT_ABBREV, since that's what the word "DEFAULT" actually comes > from. We would probably need to be a bit careful here. By default plumbing commands do not abbreviate, while we do want the default abbreviation in our Porcelains. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html