Re: [PATCH 3/4 v2] Allow detached form (e.g. "git log --grep foo") in log options.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jul 28, 2010 at 09:41, Matthieu Moy <Matthieu.Moy@xxxxxxx> wrote:

Here's a better commit message, the subject was >50 chars> (see
Documentation/SubmittingPatches):

    Subject: git-log: Parse detached options like --grep foo

    Change the option parsing logic in revision.c to accept detached forms
    like `--grep foo' in addition to `--grep=foo'. The rest of git already
    accepted this form, but revision.c still used its own option parsing.

> +test_expect_success 'log --grep option parsing' '
> +       echo second >expect &&
> +       git log -1 --pretty="tformat:%s" --grep sec >actual &&
> +       test_cmp expect actual &&
> +       test_must_fail git log -1 --pretty="tformat:%s" --grep
> +'

There's a lot of behavior change in this series, but only two small
tests that I can see. It would be easy to change the parsing code back
without triggering a regression test.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]