Hmm, ok. So if I'm not mistaken, the only outstanding issue is
whether to provide a way to globally disable git-shell-commands. Do
you have a particular threat model in mind?
Greg
On Tue, Jul 27, 2010 at 10:41 AM, Jonathan Nieder <jrnieder@xxxxxxxxx> wrote:
> Johannes Sixt wrote:
>
>> Windows does have execv. The patch is OK in this regard.
>
> Thanks, that’s a comfort. Sorry to spread misinformation.
> ---
> diff --git a/compat/mingw.c b/compat/mingw.c
> index 9a8e336..9212a12 100644
> --- a/compat/mingw.c
> +++ b/compat/mingw.c
> @@ -854,6 +854,11 @@ static void mingw_execve(const char *cmd, char *const *argv, char *const *env)
> }
> }
>
> +void mingw_execv(const char *cmd, char *const *argv)
> +{
> + mingw_execve(cmd, argv, environ);
> +}
> +
> void mingw_execvp(const char *cmd, char *const *argv)
> {
> char **path = get_path_split();
> diff --git a/compat/mingw.h b/compat/mingw.h
> index 3b2477b..d81b2f3 100644
> --- a/compat/mingw.h
> +++ b/compat/mingw.h
> @@ -237,6 +237,9 @@ pid_t mingw_spawnvpe(const char *cmd, const char **argv, char **env,
> void mingw_execvp(const char *cmd, char *const *argv);
> #define execvp mingw_execvp
>
> +void mingw_execv(const char *cmd, char *const *argv);
> +#define execv mingw_execv
> +
> static inline unsigned int git_ntohl(unsigned int x)
> { return (unsigned int)ntohl(x); }
> #define ntohl git_ntohl
> --
>
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html