On Sun, 25 Jul 2010, Junio C Hamano wrote: > Elijah Newren <newren@xxxxxxxxx> writes: > > > Signed-off-by: Elijah Newren <newren@xxxxxxxxx> > > --- > > I'm not sure if this is too trivial to submit, but I noticed it while > > poking around in upload-pack. > > > > Ever since f0cea83f631689331fce73b51f22707e897f7939, the > > 'create_full_pack' argument has been unused and is always false. We > > can make it clear that this argument is currently unused and remove some > > associated code from an 'if' block. > > While it is true that currently we memset(&rev_list) to always pass NULL > there, I wonder if that was an unintended behaviour change introduced by > the commit you mentioned... I don't think so. Especially since now do_rev_list() is only used for shallow clones/fetches, there can never be a full pack in that case. The create_full_pack logic remans present and local to create_pack_file(). Nicolas -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html