On Sun, Jul 25, 2010 at 00:59, Jonathan Nieder <jrnieder@xxxxxxxxx> wrote: > Some cleanups to make this test script easier to read and use, > such as: > > - put setup code in test_expect_success scripts to make the > test script easier to scan through; > > - avoid a pipe to test_decode_color that forgets the exit status of > "git status", by redirecting to a temporary file (named "actual") > for that function to consume instead; > > - remove precomputed object IDs; > > - reset configuration after each test, so there is less state > for a reader to keep in mind. These changes are all good. Well spotted with the test_might_fail() additions, adding forgotten &&, and turning the >expect code setup into their own tests. Acked. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html