Re: [WIP/RFC 09/13] git notes merge: Initial implementation handling trivial merges only

[Stephen Boyd <bebarino@xxxxxxxxx>]

 On 07/23/2010 03:15 AM, Johan Herland wrote:
> +	if (1<  argc) {
> +		error("too many parameters");
> +		usage_with_options(git_notes_merge_usage, options);
> +	} else if (1>  argc) {
> +		error("too few parameters");
> +		usage_with_options(git_notes_merge_usage, options);
> +	}
> +

Looks like it only takes one <notes_ref>. In that case wouldn't it be better to say

    if (argc != 1) {
        error("Must specify a note ref to merge");
        usage_with_options(git_notes_merge_usage, options)
    }

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html