Re: [PATCH 1/2] worktree setup: return to original cwd if prefix is set NULL

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



2010/7/24 Ævar Arnfjörð Bjarmason <avarab@xxxxxxxxx>:
> 2010/7/23 Nguyễn Thái Ngọc Duy <pclouds@xxxxxxxxx>:
>
>> +test_expect_success 'cwd is unchanged when prefix is NULL (from within a repo)' '
>> +       (
>> +               cd repo.git/objects &&
>> +               echo 1 > one &&
>> +               cp one expected &&
>> +               echo 2 >> expected &&
>> +               git apply patch &&
>> +               test_cmp expected one &&
>> +               rm one expected patch
>> +       )
>> +'
>
> Is the rm at the end needed here?
>
> This is a minor nit, but it's generally helpful for debugging tests
> that things aren't removed if the --debug option is specified.
>

I don't want to pollute the repo early. If the test fails, rm would not be run.
-- 
Duy
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]