Re: [PATCH 1/7] revert: fix off by one read when searching the end of a commit subject

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Christian Couder wrote:

> +++ b/builtin/revert.c
> @@ -131,7 +131,7 @@ static int get_message(const char *raw_message, struct commit_message *out)
>  		p++;
>  	if (*p) {
>  		p += 2;
> -		for (eol = p + 1; *eol && *eol != '\n'; eol++)
> +		for (eol = p; *eol && *eol != '\n'; eol++)
>  			; /* do nothing */
>  	} else
>  		eol = p;

Good catch.  For what it’s worth, this and the rest of the series is

Acked-by: Jonathan Nieder <jrnieder@xxxxxxxxx>

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]