On Thu, Jul 22, 2010 at 19:15, Brandon Casey <casey@xxxxxxxxxxxxxxx> wrote: > From: Brandon Casey <drafnel@xxxxxxxxx> > > On systems with an echo which defaults to the XSI-conformant behavior > (Solaris, or others using Ksh), echo will interpret certain backslashed > characters as control sequences. This can cause a problem for interactive > rebase when it is used to rebase commits whose commit "subject" (the first > line) contains any of these backslashed sequences. In this case, echo will > substitute the control sequence for the backslashed characters and either > the rebased commit message will differ from the original, or the rebase > process will fail. Neither is desirable. > > So work around this issue by replacing the echo statements used to print > out portions of the commit message, with printf. > > Also, add a test to test for this breakage. This looks good, especially the test for it: Acked-by: Ævar Arnfjörð Bjarmason <avarab@xxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html