Re: [PATCH] t2017: redo physical reflog existance check

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Erick Mattos <erick.mattos@xxxxxxxxx> writes:

> Although this is not a problem to all the other changes, it is laming to
> the tenth test.  The implementation of the correspondent problem creates
> a "touch" reflog that must be wiped out if not used by committing the
> new branch.

I thought about it a bit when I sent out my patch, but I do not think that
is necessary.

The things you care about, after running "-l --orphan eta", are:

 - If you make a commit, you get eta@{...} reflog that records it; and

 - If you leave the still-to-be-born eta branch without making a commit,
   you do not leave eta@{...} reflog behind.

Your zeta@{...} test is about the former, and your eta@{...} test is about
the latter.  I think they already check what they want to see happen.

I also am afraid that the "test -f" check would expose the implementation
detail more than necessary.  We may want to come up with a different
implementation of this behaviour later that may not create an empty file
there.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]