On 07/20/2010 01:00 PM, Junio C Hamano wrote: > How about being more explicit? > > Run a git command and ensure it fails in a controlled way. Use > this instead of "! <git-command>". When git-command dies due to a > segfault, test_must_fail diagnoses it as an error; "! <git-command>" > treats it as just another expected failure. letting such a bug go > unnoticed. Much better. If you want the last sentence to be grammatically correct, you could rephrase it like this: ...just another expected failure, which would let such a bug go unnoticed. -brandon -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html