Hi Ralf! Ralf Thielow wrote: > Remove duplicate code and not needed break statement. This looks like a reasonable change, with the nice effect of getting read_pack_info_file() to almost fit in one screen. The commit message is not super clear. I would say: Subject: update-server-info: Shorten read_pack_info_file() The correct responses to a D and a T line in .git/objects/info/packs are the same, so combine their case arms. In both cases we already ‘goto’ out of the switch so while at it, remove a redundant ‘break’ to avoid yet another line of code. i.e., impact in the subject line, details in the commit message body. It is missing a sign-off. See Documentation/SubmittingPatches for what that means. Hope that helps, Jonathan -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html