On Thu, 15 Jul 2010, Pavan Kumar Sunkara wrote: > Create Gitweb::Util module in 'gitweb/lib/Gitweb/Util.pm' > to store the git utility subroutines related to gitweb. > > This module include subroutines in various categories > such as git utility subs invoking git commands, git > utility subs accessing git repository, mimetype related > subs and HTML output utility subs. O.K. so the theme is small helper subroutines, isn't it? > > Subroutines moved: > git_get_head_hash > git_get_full_hash > git_get_short_hash > git_get_hash > git_get_type > git_get_hash_by_path > git_get_path_by_hash > git_get_last_activity > git_get_references > git_get_rev_name_tags > git_get_heads_list > git_get_tags_list > mimetype_guess_file > mimetype_guess > blob_mimetype > blob_contenttype > guess_file_syntax > run_highlighter > fill_from_file_info > is_deleted > is_patch_split Just a question: shouldn't git_get_last_activity subroutine be in Gitweb::RepoConfig module? Or is Gitweb::RepoConfig only about "static" properties of a repository? > > Update 'gitweb/Makefile' to install Gitweb::Util alongside gitweb. > > Signed-off-by: Pavan Kumar Sunkara <pavan.sss1991@xxxxxxxxx> > --- I have not checked the patch, but is should be mainly straightforward code movement plus some boilerplate. -- Jakub Narebski Poland -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html