Re: [PATCH/RFC 4/4] Add interactive mode to git-shell for user-friendliness

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Greg,

Greg Brockman wrote:

> - Extend run_command to optionally use execv.  Would any other code
> actually want this functionality though?  If not, it's probably an
> excessively large code change for little benefit.

Of the options you presented, this is the best one.  It doesn’t matter
whether any other code would use it; even if you are the only caller,
it is still good because

 - if someone else needs the facility, it will be obvious where
   to find it

 - you can share the existing logic to portably run a command
   (i.e., near free portability to msys).

run_command() already takes an argument for options like
RUN_USING_SHELL; your new facility would fit right in.

But first a more basic question: why not just add “./” to the start of
the command name?
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]