On Fri, Jul 16, 2010 at 15:35, Ævar Arnfjörð Bjarmason <avarab@xxxxxxxxx> wrote:
> git-pickaxe (later git-blame) gained support for the -L/start/,/end/
> form in 2006 (931233bc66 by Junio C Hamano), but nothing was added to
> test this functionality. Change that by adding more -L tests to
> t8003-blame.sh.
I was also going to patch t8003-blame.sh to test for the functionality
introduced in 7bd9641df5, but I'm not sure what it's supposed to do:
ok:
$ git blame cow
5b22ca36 (Fourth 2005-04-07 15:16:13 -0700 1) ABC
5b22ca36 (Fourth 2005-04-07 15:16:13 -0700 2) DEF
018e3134 (Fifth 2005-04-07 15:17:13 -0700 3) XXXX
5b22ca36 (Fourth 2005-04-07 15:16:13 -0700 4) GHIJK
ok:
$ git blame -L 1,2 cow
5b22ca36 (Fourth 2005-04-07 15:16:13 -0700 1) ABC
5b22ca36 (Fourth 2005-04-07 15:16:13 -0700 2) DEF
ok, +/- are zero-indexed:
$ git blame -L 1,+2 cow
5b22ca36 (Fourth 2005-04-07 15:16:13 -0700 1) ABC
5b22ca36 (Fourth 2005-04-07 15:16:13 -0700 2) DEF
Shouldn't this either print nothing, er be an error:
$ git blame -L 1,+0 cow
5b22ca36 (Fourth 2005-04-07 15:16:13 -0700 1) ABC
5b22ca36 (Fourth 2005-04-07 15:16:13 -0700 2) DEF
same here, line 0-0 prints the whole file:
$ git blame -L 0,0 cow
5b22ca36 (Fourth 2005-04-07 15:16:13 -0700 1) ABC
5b22ca36 (Fourth 2005-04-07 15:16:13 -0700 2) DEF
018e3134 (Fifth 2005-04-07 15:17:13 -0700 3) XXXX
5b22ca36 (Fourth 2005-04-07 15:16:13 -0700 4) GHIJK
And these need a better error message:
$ git blame -L 0,0a cow
usage: git blame [options] [rev-opts] [rev] [--] file
Is there any use for +/- 0, or should it always be an error?
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html