Re: [PATCH resend] Only run aggregate-results over actual counts

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jul 16, 2010 at 09:37, Thomas Rast <trast@xxxxxxxxxxxxxxx> wrote:
> The current make target 'aggregate-results' scanned all files matching
> test-results/t*-*.  Normally these are only the test counts (and the
> exit values, which are ignored), but with --tee the suite also dumps
> all output.  Furthermore, with --verbose t1450 contains several lines
> starting with "broken link from ..." which matches the criteria used
> by aggregate-results.sh.
>
> Rename the counts output files to *.counts, and only scan those.
>
> Signed-off-by: Thomas Rast <trast@xxxxxxxxxxxxxxx>
> Acked-by: Sverre Rabbelier <srabbelier@xxxxxxxxx>

Acked-by: Ævar Arnfjörð Bjarmason <avarab@xxxxxxxxx>

> --- a/t/test-lib.sh
> +++ b/t/test-lib.sh
> @@ -635,7 +635,7 @@ test_done () {
>        GIT_EXIT_OK=t
>        test_results_dir="$TEST_DIRECTORY/test-results"
>        mkdir -p "$test_results_dir"
> -       test_results_path="$test_results_dir/${0%.sh}-$$"
> +       test_results_path="$test_results_dir/${0%.sh}-$$.counts"
>
>        echo "total $test_count" >> $test_results_path
>        echo "success $test_success" >> $test_results_path

For Junio: FYI this bumps into my "test-lib: Don't write test-results
when HARNESS_ACTIVE" patch in flight. The fixup is trivial though.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]