On Thu, 15 Jul 2010, Pavan Kumar Sunkara wrote: > Create a Gitweb::RepoConfig module in 'gitweb/lib/Gitweb/RepoConfig.pm' > to store and handle all the configuration and subroutines > related to a single repository regarding the gitweb.perl script. The above sentence is hard to parse (hard to understand). Please try to be more clear. I guess that you wanted to say that this module is about checking repositories and repository parameters, and about per-repository configuration. > > This module depend on several other modules like Git.pm, > Config.pm, Request.pm and Escape.pm. Nitpick: the names of those modules are Gitweb::Git, Gitweb::Config, Gitweb::Request and Gitweb::Escape. > > It also include subroutines regarding project_list and > it's handling. > > Subroutines moved: > check_head_link > check_export_ok > hash_set_multi > git_parse_project_config > config_to_bool > config_to_int > config_to_multi > feature_bool > feature_snapshot > feature_patches > feature_avatar > git_get_project_config > git_get_project_description > git_get_project_ctags > git_populate_project_tagcloud > git_show_project_tagcloud > git_get_project_url_list > git_get_projects_list > git_get_project_list_from_file > git_get_project_owner > get_file_owner > project_in_list In the future we might want to separate handling of per-repository overriding of features in a separae module. > > Update gitweb/Makefile to install Gitweb::RepoConfig module > alongside gitweb > > Signed-off-by: Pavan Kumar Sunkara <pavan.sss1991@xxxxxxxxx> Other than those minor issues it seems all right. P.S. I'm sorry, but I wouldn't be able to examine the rest of series before this Sunday at earliest. -- Jakub Narebski Poland -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html