On Thu, 15 Jul 2010, Pavan Kumar Sunkara wrote: > Create a Gitweb::Request module in 'gitweb/lib/Gitweb/Request.pm' > to store and handle all the cgi params and related variables > regarding the gitweb.perl script. > > This module is intended as standalone module, which does not require > (include) other gitweb' modules to avoid circular dependencies. > > Subroutines moved: > evaluate_uri > evaluate_query_params Here you would really need to explain why Gitweb::Request does not include evaluate_path_info, the companion to evaluate_query_params. It is strange to me that query_params is in it, but path_info is not. Would it be possible, perhaps, to modify evaluate_path_info so it can be moved to Gitweb::Request without adding additional dependencies to it? > Update gitweb/Makefile to install Gitweb::Request module alongside gitweb > > Signed-off-by: Pavan Kumar Sunkara <pavan.sss1991@xxxxxxxxx> [...] > --- /dev/null > +++ b/gitweb/lib/Gitweb/Request.pm [...] > +our @EXPORT = qw($cgi $my_url $my_uri $base_url $path_info $home_link $action $project $file_name > + $file_parent $hash $hash_parent $hash_base $hash_parent_base @extra_options $page > + $searchtype $search_use_regexp $searchtext $search_regexp %input_params %allowed_options > + @cgi_param_mapping %cgi_param_mapping $t0 evaluate_query_params evaluate_uri); You are working off older base, which did not include reset_timer subroutine, added in 869d588 (gitweb: Move evaluate_gitweb_config out of run_request, 2010-07-05). -- Jakub Narebski Poland -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html