Re: [PATCH] fast-import: export correctly marks larger than 2^20-1

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



(+cc David, who I think mentioned wishing for something like this)

Raja R Harinath wrote:

> Subject: fast-import: export correctly marks larger than 2^20-1

Thank you!  That would be a very good thing.

> dump_marks_helper() has a bug when dumping marks larger than 2^20-1,
> i.e., when the sparse array has more than two levels.  The bug was
> that the 'base' counter was being shifted by 20 bits at level 3, and
> then again by 10 bits at level 2, rather than a total shift of 20 bits
> in this argument to the recursive call:

I haven’t read or grokked that code you are changing, so I can’t
comment on the substance of your patch.  In case no one with such
knowledge turns up, could you give a quick summary of what the
existing code does and why?

Barring that, v1.5.0-rc4~14^2~61 (Added option to export the marks
table when fast-import terminates., 2006-08-25) might be a good
starting point for a person looking to understand.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]