On 10/24/06, Josef Weidendorfer <Josef.Weidendorfer@xxxxxx> wrote:
On Tuesday 24 October 2006 18:47, Marco Costalba wrote: > When changing graph size with CTRL+ and CTRL- > update also tag/branch marks. > > Also little cleanup. > --- > > Hi Josef, > > please tell me if you are working on the same files, in this case I > will step back and wait you to finish your patch series and eventually > resubmit this one at the end. No, that is fine. Currently, I have not much time. Just curious: What did you expect next in my patch series? :-)
Quoting from your last e-mail: "The new painting code regroups the drawing commands in multiple switch-statements to prepare for far simpler code with booleans for different elements, and not one type only." Indeed it's not clear to me what the above line means exactly, it just smells like there is something more cooking. Sorry If I've misunderstood.
Now that everything is drawn directly, the question is what to do with the new flexibility. E.g. we _could_ implement different graph drawing algorithms next to the original qgit one, e.g. mimicking gitk.
One little secret of current algorithm is that it just needs to know the "state" of previous revision graph to calculate the next one. (see Git::updateLanes() and lanes.cpp), it's a kind of a "rasterized" graph drawing, i.e. line by line. I didn't studied gitk in deep but it seems a little bit less simpler. Anyway if you are interested it's for sure worth trying ;-) Marco - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html