Re: [PATCH 2/2] revert: don't print "Finished one cherry-pick." if commit failed

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Christian Couder wrote:

> And, while at it, refactor commit code into a new run_git_commit()
> function.

Probably should be two patches.

> +++ b/builtin/revert.c
> @@ -492,48 +518,17 @@ static int do_pick_commit(void)
>  			mebuf.buf, help_msg());
>  		rerere(allow_rerere_auto);
>  	} else {
> -		fprintf(stderr, "Finished one %s.\n", mebuf.buf);
> +		if (!no_commit)
> +			res = run_git_commit(defmsg);
> +		if (!res)
> +			fprintf(stderr, "Finished one %s.\n", mebuf.buf);
>  	}

Ack for this part.  Thanks.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]