04ece59 (GIT_SKIP_TESTS: allow users to omit tests that are known to break, 2006-12-28)
introduced GIT_SKIP_TESTS, and since then we have had two nested loops
iterating over GIT_SKIP_TESTS with the same loop variable.
Reduce this to one loop.
Signed-off-by: Michael J Gruber <git@xxxxxxxxxxxxxxxxxxxx>
---
I am probably making a complete shell fool out of myself by overlooking
something completely trivial.
But just in case I am not, this reduces the loop from O(N^2) to O(N), although
I do admit that N is typically not that large...
(Note that the inner $skp does not overwrite the outer one, at least not with bash.)
t/test-lib.sh | 23 ++++++++++-------------
1 files changed, 10 insertions(+), 13 deletions(-)
diff --git a/t/test-lib.sh b/t/test-lib.sh
index ac496aa..8e3de53 100644
--- a/t/test-lib.sh
+++ b/t/test-lib.sh
@@ -827,23 +827,20 @@ cd -P "$test" || exit 1
this_test=${0##*/}
this_test=${this_test%%-*}
+to_skip=
for skp in $GIT_SKIP_TESTS
do
- to_skip=
- for skp in $GIT_SKIP_TESTS
- do
- case "$this_test" in
- $skp)
- to_skip=t
- esac
- done
- case "$to_skip" in
- t)
- say_color skip >&3 "skipping test $this_test altogether"
- say_color skip "skip all tests in $this_test"
- test_done
+ case "$this_test" in
+ $skp)
+ to_skip=t
esac
done
+case "$to_skip" in
+t)
+ say_color skip >&3 "skipping test $this_test altogether"
+ say_color skip "skip all tests in $this_test"
+ test_done
+esac
# Provide an implementation of the 'yes' utility
yes () {
--
1.7.2.rc1.212.g850a
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html