Re: [RFC] war on echo in scripts

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Andreas Schwab wrote:
> Jonathan Nieder <jrnieder@xxxxxxxxx> writes:

>>  die() {
>> -	echo >&2 "$@"
>> +	printf >&2 '%s\n' "$@"
>
> You probably want to use "$*" here, though it wouldn't matter for the
> uses of die in this file.

Hmm, maybe something like this would be easier.

Signed-off-by: Jonathan Nieder <jrnieder@xxxxxxxxx>
---
diff --git a/git-sh-setup.sh b/git-sh-setup.sh
index 6131670..b38b40b 100644
--- a/git-sh-setup.sh
+++ b/git-sh-setup.sh
@@ -39,6 +39,10 @@ git_broken_path_fix () {
 
 # @@BROKEN_PATH_FIX@@
 
+echo() {
+	printf '%s\n' "$*"
+}
+
 die() {
 	echo >&2 "$@"
 	exit 1
-- 
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]