Re: [PATCH] t/t0006: specify timezone as EST5 not EST to comply with POSIX

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jul 06, 2010 at 06:34:20PM -0500, Brandon Casey wrote:

> From: Brandon Casey <drafnel@xxxxxxxxx>
> 
> POSIX requires that both the timezone "standard" and "offset" be specified
> in the TZ environment variable.  This causes a problem on IRIX which does
> not understand the timezone 'EST'.
> 
> Signed-off-by: Brandon Casey <casey@xxxxxxxxxxxxxxx>
> ---
> 
> I guess 'EST' is an alias? for EST5EDT?  Linux and Solaris both grok EST
> just fine.  POSIX says the offset is required.  I don't see any mention of
> aliases.

Yeah, I believe it is the same as EST5EDT. Which time zone isn't really
important. The main thing is that it be a negative offset from UTC, and
that we be able to convert the zone name into a numeric offset for the
date specified in the test (which is totally arbitrary and can be
tweaked if need be to avoid daylight saving issues).

So I think your patch is fine, but we can look harder if somebody finds
a platform that doesn't understand EST5.

-Peff
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]