[PATCH 1/2] Add a string_list_foreach macro

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



This is more lightweight than for_each_string_list function with
callback function and a cookie argument.

Signed-off-by: Alex Riesen <raa.lkml@xxxxxxxxx>
---

Alex Riesen, Tue, Jun 29, 2010 10:35:15 +0200:
> On Tue, Jun 29, 2010 at 10:33, Alex Riesen <raa.lkml@xxxxxxxxx> wrote:
> > BTW, now that I took a look at it... The iteration over string_list
> > items looks a little overengineered. At least from the point of
> > view of the existing users of the feature. Wouldn't a simple loop
> > be just as simple to use (if not simplier) and faster (no uninlineable
> > function calls and argument preparation and passing needed)?
> >
> > #define string_list_foreach(item,list) \
> >        for (item = (list)->items; item < (list)->items + (list)->nr; ++item)
> >

Rebased on current head (after Julian Philips patches).

 string-list.h |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/string-list.h b/string-list.h
index 680d600..acf0450 100644
--- a/string-list.h
+++ b/string-list.h
@@ -24,6 +24,8 @@ void string_list_clear_func(struct string_list *list, string_list_clear_func_t c
 typedef int (*string_list_each_func_t)(struct string_list_item *, void *);
 int for_each_string_list(struct string_list *list,
 			 string_list_each_func_t, void *cb_data);
+#define string_list_foreach(item,list) \
+	for (item = (list)->items; item < (list)->items + (list)->nr; ++item)
 
 /* Use these functions only on sorted lists: */
 int string_list_has_string(const struct string_list *list, const char *string);
-- 
1.7.1.304.g8446

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]