On Thu, Jul 01, 2010 at 08:17:50PM +0000, Ævar Arnfjörð Bjarmason wrote: > This is v2 of the t/README series. It should address the concerns > Junio and Jeff had about it. > > Jeff: > > - Keep the ./ way of running tests, but elaborate a bit in the > commit message > > - Mention --root's effects on the trash directory location Thanks. On the first point, I agree with Junio that dropping patch 1 is probably the best thing. For the second, your changes to patch 2 look good to me. The rest look OK from my cursory read. I like the "do's and don'ts" list, which is a good way of communicating the little bits of wisdom (btw, I saw your post a few weeks ago about shell portability in git, and I think a list of known-bad constructs would be a good idea. Making a list from our previous fixes is on my todo list, but I haven't actually started on it. :) ). One nit: > + You can gleam some further possible issues from the TAP grammar > + (see http://search.cpan.org/perldoc?TAP::Parser::Grammar#TAP_Grammar) > + but the best indication is to just run the tests with prove(1), > + it'll complain if anything is amiss. I think you mean "glean". -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html